feat: APP-2977 - Implement AssetTransfer module component #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgero-eth
reviewed
Apr 3, 2024
cgero-eth
reviewed
Apr 3, 2024
… parent component AssetTransfer
cgero-eth
changed the title
thekidnamedkd
commented
Apr 5, 2024
cgero-eth
reviewed
Apr 8, 2024
src/modules/components/asset/assetTransfer/assetTransferAddress/index.ts
Outdated
Show resolved
Hide resolved
src/modules/components/asset/assetTransfer/assetTransferAddress/assetTransferAddress.tsx
Outdated
Show resolved
Hide resolved
src/modules/components/asset/assetTransfer/assetTransferAddress/assetTransferAddress.tsx
Outdated
Show resolved
Hide resolved
src/modules/components/asset/assetTransfer/assetTransferAddress/assetTransferAddress.tsx
Outdated
Show resolved
Hide resolved
src/modules/components/asset/assetTransfer/assetTransferAddress/assetTransferAddress.tsx
Outdated
Show resolved
Hide resolved
…ction, new prop naming, ICompositeAddress type, etc
cgero-eth
reviewed
Apr 9, 2024
There was a problem hiding this comment.
Component looks great now, well done @thekidnamedkd 👏🏻
Left a couple of comments and a question for @Fabricevladimir
src/modules/components/asset/assetTransfer/assetTransfer.stories.tsx
Outdated
Show resolved
Hide resolved
src/modules/components/asset/assetTransfer/assetTransferAddress/assetTransferAddress.test.tsx
Outdated
Show resolved
Hide resolved
src/modules/components/asset/assetTransfer/assetTransferAddress/assetTransferAddress.test.tsx
Outdated
Show resolved
Hide resolved
src/modules/components/asset/assetTransfer/assetTransferAddress/assetTransferAddress.tsx
Outdated
Show resolved
Hide resolved
…e ENS check, require address on participants
cgero-eth
reviewed
Apr 10, 2024
cgero-eth
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
implement AssetTransfer module component with tests and stories
Task: APP-2977
Type of change
Checklist:
CHANGELOG.mdfile in the root folder of the package after the [UPCOMING] title and beforethe latest version.